Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Kedro-Viz python version support policy #2086

Closed
rashidakanchwala opened this issue Sep 10, 2024 · 6 comments
Closed

Document Kedro-Viz python version support policy #2086

rashidakanchwala opened this issue Sep 10, 2024 · 6 comments

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Sep 10, 2024

Description

Kedro-viz will follow the Kedro Framework Python version policy, which means it will support all Python versions that are actively maintained by the CPython core team. Once a Python version reaches its end of life, we will stop supporting it in kedro-viz without considering it a breaking change. This ensures that Kedro-viz will remain compatible with all Kedro projects, even for users on older supported Python versions.

@rashidakanchwala
Copy link
Contributor Author

@astrojuanlu , @merelcht , @ravi-kumar-pilla

I also want to add this to Kedro-viz docs, any suggestion where I should add it.

@ravi-kumar-pilla
Copy link
Contributor

Hi @rashidakanchwala , I think README.md should be a good place, similar to kedro - https://github.com/kedro-org/kedro?tab=readme-ov-file#python-version-support-policy

Do you mean to add it in docs other than README ?

@merelcht
Copy link
Member

Just to clarify and have it documented somewhere: does this mean kedro-datasets will need to follow the more conservative policy again as well or can Viz now handle it if datasets drops support for a Python version?

@merelcht
Copy link
Member

Deprecation warnings will be issued in advance for any features or Python versions that are being removed.

How do you plan to do this? In a Slack announcement or inside the actual code? We never do this in Kedro Framework.

@rashidakanchwala
Copy link
Contributor Author

As discussed over call; since DeprecationWarnings for Python versions are not common and Kedro doesn't do it, we will do the same thing on Kedro-Viz.

Also, given that kedro-viz and kedro-datasets are no longer coupled. This change shouldn't impact kedro-datasets.

@rashidakanchwala rashidakanchwala moved this to Backlog in Kedro-Viz Sep 23, 2024
@rashidakanchwala rashidakanchwala changed the title Kedro-Viz python version support policy Document Kedro-Viz python version support policy Sep 23, 2024
@rashidakanchwala rashidakanchwala self-assigned this Sep 27, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Sep 30, 2024
@rashidakanchwala rashidakanchwala moved this from Todo to In Review in Kedro-Viz Oct 14, 2024
@rashidakanchwala rashidakanchwala moved this from In Review to Done in Kedro-Viz Oct 14, 2024
@rashidakanchwala
Copy link
Contributor Author

Done here #2139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants