Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Fix bug experiment data not showing on Windows #763

Closed
1 task done
merelcht opened this issue Mar 1, 2022 · 5 comments
Closed
1 task done

[BE] Fix bug experiment data not showing on Windows #763

merelcht opened this issue Mar 1, 2022 · 5 comments
Assignees

Comments

@merelcht
Copy link
Member

merelcht commented Mar 1, 2022

Description

Internal user Sanjay, reported a bug on Windows where his experiment data is being tracked properly, can be shown in the pipeline view, but doesn't appear in the experiment tracking view.

Context

Can't view experiment data.

Steps to Reproduce

  1. Setup experiment tracking session store + datasets
  2. kedro run
  3. kedro viz

Expected Result

The logged experiment data should appear in the experiment tracking view.

Actual Result

Only the data from the session store is shown with the names of the tracked datasets, but not the actual content.
image (12)

2022-02-10 16:27:39,359 - kedro_viz.api.graphql - WARNING - `C:\Users\s_hariharan\...\evaluation.json` could not be found

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: N/A
  • Operating system and version: Windows
  • NodeJS version used (if relevant): N/A
  • Kedro version used (if relevant): N/A
  • Python version used (if relevant): N/A

Notes

@studioswong and I already had a stab at finding out what the issue is. It looks like the issue is in https://github.com/kedro-org/kedro-viz/blob/main/package/kedro_viz/api/graphql.py#L212, specifically the logic to check if the file exists: https://github.com/kedro-org/kedro-viz/blob/main/package/kedro_viz/api/graphql.py#L244.

We haven't fully verified this, but my guess is that for some reason this check doesn't pass on Windows and therefore no data is returned. The data was logged properly and the REST API does return it.

Checklist

  • Include labels so that we can categorise your issue
@rashidakanchwala
Copy link
Contributor

Hi @MerelTheisenQB do you know if Sanjay or his team had their pipeline-viz working on Mac. Also, do we have a Windows laptop in Kedro-team to test this ?

@tynandebold tynandebold changed the title [BE] Fix bug experiment data not showing [BE] Fix bug experiment data not showing on Windows Mar 7, 2022
@tynandebold tynandebold moved this to Backlog in Kedro-Viz Mar 7, 2022
@merelcht
Copy link
Member Author

merelcht commented Mar 8, 2022

Hi @MerelTheisenQB do you know if Sanjay or his team had their pipeline-viz working on Mac. Also, do we have a Windows laptop in Kedro-team to test this ?

As far as I understood they had to use Windows. It was a very restricted environment, so Sanjay couldn't share any code other than what he showed through a call and the photo above.

@merelcht merelcht moved this from Backlog to Todo in Kedro-Viz Mar 14, 2022
@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Mar 17, 2022

@AntonyMilneQB -- hey, I got Kedro-viz to run on my personal Windows Machine and nothing is committing to the session_store.db on every kedro run. For me, it shows no experiment tracking data on Kedro-viz. I can bring my laptop next week so we can debug in person.

@antonymilne
Copy link
Contributor

@rashidakanchwala interesting 🤔 Let's take a look next week indeed!

@antonymilne
Copy link
Contributor

Same issue reported here: kedro-org/kedro#1359

@tynandebold tynandebold moved this from Todo to In Progress in Kedro-Viz Mar 25, 2022
@rashidakanchwala rashidakanchwala moved this from In Progress to Todo in Kedro-Viz Mar 28, 2022
@rashidakanchwala rashidakanchwala moved this from Todo to In Progress in Kedro-Viz Mar 30, 2022
@rashidakanchwala rashidakanchwala moved this from In Progress to In Review in Kedro-Viz Apr 4, 2022
@rashidakanchwala rashidakanchwala moved this from In Review to Done in Kedro-Viz Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants