Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black to a non pre-release version (black==22.1.0) #1327

Closed
Galileo-Galilei opened this issue Mar 8, 2022 · 2 comments · Fixed by #1331
Closed

Update black to a non pre-release version (black==22.1.0) #1327

Galileo-Galilei opened this issue Mar 8, 2022 · 2 comments · Fixed by #1331
Labels
Community Issue/PR opened by the open-source community dependencies Pull requests that update a dependency file Issue: Feature Request New feature or improvement to existing feature

Comments

@Galileo-Galilei
Copy link
Member

Galileo-Galilei commented Mar 8, 2022

Description

The kedro template still use black==21.5b1 which is a pre-release version non covered by the stability policy of the last 22.1.0 version.

Context

I would like to be able to install a non prelease version of black and to benefit for their stability policy. I also think it is better for kedro not to rely on a pre-release version if an official release is available (e.g. to avoid warning from internal security tools).

Possible Implementation

  • Change to black==22.1.0 in the template requirements
  • Update the files of the template with the new black version (a couples of files have some lines splitted differently). This is completely straightforward.

Unless I miss something which would have some other impact, I can open a PR.

Possible Alternatives

Let people change the black version themselves in their templates. Since click was upgraded in #1193 , this will be possible in kedro=0.18. I do not really like this option (you have to remember to do this each time you start a kedro project + you have a first commit with pure formatting change which is less readable) but this would be a possible workaround.

@Galileo-Galilei Galileo-Galilei added the Issue: Feature Request New feature or improvement to existing feature label Mar 8, 2022
@Galileo-Galilei Galileo-Galilei changed the title Update black to a non pre-release version (black==2.1.0) Update black to a non pre-release version (black==22.1.0) Mar 8, 2022
@antonymilne
Copy link
Contributor

Hi @Galileo-Galilei, thanks for pointing this out. Your proposed solution sounds good - please do go ahead and open a PR. If you don't mind raising one for https://github.com/kedro-org/kedro-starters also then that would be great also. Since the click requirement has only been bumped for develop, I presume the black version change will only work in kedro 0.18? In which case you should make the kedro-starters PR's target branch = 0.18.0.

Somewhat related - interested in your thoughts on #1293 if you get a chance to look at it. And also I finally got around to thinking about this and I think you will like the result 😄

@merelcht merelcht added the Community Issue/PR opened by the open-source community label Mar 8, 2022
@Galileo-Galilei
Copy link
Member Author

Thank you, I've done it for the main repo and I'll do it for the starters soon. I am quite busy right now but I've seen your reply on above thread (thank you for this!) and will answer as soon as i can.

@merelcht merelcht linked a pull request Mar 14, 2022 that will close this issue
5 tasks
@merelcht merelcht added the dependencies Pull requests that update a dependency file label Mar 15, 2022
@merelcht merelcht moved this to Done in Kedro Framework Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community dependencies Pull requests that update a dependency file Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants