Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Global _active_session and provide a better alternative (Parent) #1441

Closed
2 of 3 tasks
noklam opened this issue Apr 14, 2022 · 3 comments
Closed
2 of 3 tasks
Labels
Stage: Technical Design 🎨 Ticket needs to undergo technical design before implementation

Comments

@noklam
Copy link
Contributor

noklam commented Apr 14, 2022

Notes:

  1. The scope of this PR will be limited to an ad-hoc fix so it doesn't block new session in Jupyter/Databricks environment when an active session is not closed.
  2. The discussion of removing global _active_session will be deferred. Particularly, we will need more information about how the plugins developers are using it and do we need to expose more. Potentially adding new hooks/changing hookspec or some more thinking about the responsibility of KedroSession & KedroContext.

Originally posted by @noklam in #1434 (comment)

Follow up issues/PRs:

@noklam noklam added the Stage: Technical Design 🎨 Ticket needs to undergo technical design before implementation label Apr 14, 2022
@antonymilne
Copy link
Contributor

antonymilne commented Apr 14, 2022

See #506 for some discussion of adding new arguments to the hook spec or creating a whole new hook. My initial proposal: #506 (comment)

@noklam
Copy link
Contributor Author

noklam commented Apr 20, 2022

Conclusion from today's discussion:

  • Turn KedroContext into a dataclass
  • Add the config_loader property so people don’t need to use context._getconfig_loader
  • Add after_context_created hook and include KedroContext in the signature.
    For 0.19 - deprecating catalog and param hot reload.

@merelcht merelcht moved this to Todo in Kedro Framework Apr 25, 2022
@noklam noklam changed the title Clean up the Global _active_session and provide a better alternative Clean up the Global _active_session and provide a better alternative (Parent) Apr 27, 2022
@antonymilne antonymilne removed the status in Kedro Framework May 9, 2022
@astrojuanlu
Copy link
Member

I think most of the tasks here were done? And if there's only one task left, can we close this parent issue and leave the other one open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stage: Technical Design 🎨 Ticket needs to undergo technical design before implementation
Projects
None yet
Development

No branches or pull requests

4 participants