-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure logging.yml
is optional and tidy logging config
#1469
Milestone
Comments
antonymilne
changed the title
Ensure
Ensure Apr 22, 2022
logging.yml
is optional and remove it from all starterslogging.yml
is optional, delete it and logs
folder
Do we want to drop the file handlers from lines kedro/kedro/config/logging.yml Line 14 in e78990c
|
Maybe! See #1472. |
Speak to @AntonyMilneQB for details on approaches. |
This issue has changed a bit: see #1461 (comment) for explanation. |
antonymilne
changed the title
Ensure
Ensure May 16, 2022
logging.yml
is optional, delete it and logs
folderlogging.yml
is optional
antonymilne
changed the title
Ensure
Ensure May 16, 2022
logging.yml
is optionallogging.yml
is optional and tidy logging config
7 tasks
Repository owner
moved this from In Review
to Done
in Kedro Framework
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Must be completed after #1470.
Step 1
Delete (a) the file logging.yml and (b) the logs folder from all the following places:
No longer doing the above; see #1461 (comment).
I think you'll get an exception like this:
Catch this and emit as a debug level message instead. Write new tests/modify existing ones as needed.
kedro/config/logging.yml should remain! Don't delete that.
Step 2 - No longer doing this; see #1461 (comment).
Add the following to
configure_logging
after thelogging.config
line:Add the following logger to
kedro/config/logging.yml
:Test to make sure this works as planned. Ask me to explain what this is all about.
Step 3
Tidy up tests. Look for all places we write a logging.yml in tests and remove them.
local_logging_config
appears to be the way we do this, but check any other references to logs to make sure they should still be there.local_local_config
intests/session/confest.py
is a special case that should remain.Step 4
Manual testing: check that everything works the same in terms of console and file logging when you do a
kedro run
. Make sure you test log messages coming from different places, e.g. something emitted from within the project.The text was updated successfully, but these errors were encountered: