Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional user requirements for parametrized session_id #1609

Closed
ARashitov opened this issue Jun 10, 2022 · 5 comments
Closed

Additional user requirements for parametrized session_id #1609

ARashitov opened this issue Jun 10, 2022 · 5 comments
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@ARashitov
Copy link

ARashitov commented Jun 10, 2022

Description

Hello! I know, that you have In a backlog discussion related to parametrized session_id and as a user I would like to add mine extra requirements.

  1. As a user I want to specify (entire or prefix or suffix) of session_id as parameter in Kedro CLI
  2. As a user I want to log all data I/O operations within scope of particular session_id

(entire or prefix or suffix) - This part depends on your decision about how you will manage it

Why as user I would like to have this feature

  1. This feature would help to link node & pipeline logs with logs produced from other components in my system when I execute pipelines using kedro run command
  2. Awareness about session_id inside of functions of DatasetSpecs class would help to distinguish to which kedro session I/O operation does belong inside of logs. But I don't about degree of coupling kedro striving between KedroSession and DataCatalog classes, so I think safest is to make session_id optional to keep lowest

Importance

  1. Not critical, nice-to-have: I consider feature as nice-to-have because, I can store extra details of KedroSession as environment variable, and refer to them when I log something.
  2. Not critical, nice to have: I consider feature as nice-to-have because, I the same as above I can refer to env variable

Thanks for your support

@ARashitov ARashitov added the Issue: Feature Request New feature or improvement to existing feature label Jun 10, 2022
@noklam
Copy link
Contributor

noklam commented Jun 10, 2022

@atmosone Thanks for creating the issue, what's the motivation for this request? Does this related to #1551 ?

@ARashitov
Copy link
Author

@noklam Yes, you are correct it is related to #1551. Sorry, now understand that I should attach this content to issue created earlier

@noklam
Copy link
Contributor

noklam commented Jun 13, 2022

I am trying to summarize the information around this session_id and different use cases for our internal technical discussion. It would be great to understand the use cases. Is it the same use case that you mentioned #1571 here? or you need it for another reason?

@ARashitov
Copy link
Author

Given issue is extension to #1571 which focussed on use case of how I would like to specify session_id and how I would like to use it in kedro hooks, particularly DatasetSpecs hooks.

@noklam noklam closed this as completed Jun 14, 2022
@noklam
Copy link
Contributor

noklam commented Jun 14, 2022

Closed as duplicate #1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants