-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate removal of prompts.yml #1692
Comments
@MerelTheisenQB might have more context here on why we originally added prompts.yml and which users we should talk to if we want to change this so we can be sure we still satisfy their needs. I don't think there can be many people writing custom prompts.yml files but would be good to hear from those who do. |
The original reasoning behind adding the This is the PR that adds the logic (apologies to the community, this was added when Kedro wasn't part of the Linux Foundation yet and so it's in a private repo). |
Following the new utilities workflow #2388 we'll be expanding prompts with more options, so I'm closing this ticket. |
Is there a chance to keep this one open? I recall a conversation with @antonymilne about this issue blocking something else, I'd need to locate it... But I'm wondering if it can be decoupled from the new addons. |
Every starter template has two files, cookiecutter.json and prompts.yml. This has always been kind of confusing: they contain kind of similar information, so do you need to edit just one file or both files?. Following #1643, there's not much left in prompts.yml.
cookiecutter.json is the system used by cookiecutter; prompts.yml is a custom system we added on top of it. As far as I know there's two things that prompts.yml gives us over the cookiecutter.json file:
I believe we could handle both of these using native cookiecutter features:
The advantages would be:
The task here is to work out:
The text was updated successfully, but these errors were encountered: