Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace kedro-datasets #1693

Closed
merelcht opened this issue Jul 7, 2022 · 1 comment
Closed

Namespace kedro-datasets #1693

merelcht opened this issue Jul 7, 2022 · 1 comment
Assignees

Comments

@merelcht
Copy link
Member

merelcht commented Jul 7, 2022

Description

As discussed in Technical Design the kedro-datasets package should be namespaced to kedro.datasets

Implementation

To enable namespacing edit setup.py: https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages

  • When we do the namespace package for kedro-datasets, we also need to rename the current namespace from kedro_datasets.datasets -> kedro.datasets.

These 2 links will be useful for this ticket

While doing this, we should make sure these still works

import kedro
from kedro.datasets import *  # From kedro-dataset
from kedro.io import *  # From kedro
@AhdraMeraliQB
Copy link
Contributor

After a discussion during technical design, we have concluded that namespacing is not the correct approach for the kedro-datasets split. Further details and discussion can be seen under #1758.

Repository owner moved this from In Review to Done in Kedro Framework Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants