-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make session_id
customisable.
#1731
Comments
I am still a bit concern about letting the user to overwrite the timestamp and have their own incremental id. I think it will end up to be some incremental id or just appending on the timestamp(which is not a meaningful or human readable text anyway). If so, there are not much benefit added than by just letting user to "append" text to the id. This way we avoid the risk of messing up the order of version. It would be particular confusing if user are using both custom id logic sometimes and the default timestamp, it could end up loading the wrong version even though both are sortable and incremental id. |
I think we should have a customizable suffix and and a fixed sortable prefix |
This issue was discussed in Technical Design and we decided on the following implementation:
|
In order to use versioning and to be able to run nodes in a cloud - mostly one node at a time - current session approach doesn't work. We need a way to to be able to make sure we get to use the same session when i run different nodes in a different machines. |
@fazilhero Thanks for your comment, can you elaborate on what you need and what do you mean by "same session"?
Would this be enough to solve your problem, or you need your own way of defining the session_id? One major concern we have is the session_id is couple with versioning, and it needs to be sortable otherwise incorrect version could be loaded. |
Sure, @noklam , Imagine the following case, i have 10 noes which creates linear workflow. If I enable versioning and try to run |
For reference, we are talking about this piece of code: kedro/kedro/framework/session/session.py Lines 158 to 161 in df9f174
|
Description
#1551
Implementation
session_id
to theKedroSession.create()
methodsession_id
against theVERSION_FORMAT
format. Basically, it needs to be a timestamp of a specific format. This is to prevent users from picking a session id that will mess up the versioning system in Kedro.generate_timestamp()
method as session_id.save_version
id used for versioning.The text was updated successfully, but these errors were encountered: