Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the modular pipelines documentation to improve clarity #1998

Closed
stichbury opened this issue Nov 2, 2022 · 8 comments · Fixed by #3948
Closed

Revise the modular pipelines documentation to improve clarity #1998

stichbury opened this issue Nov 2, 2022 · 8 comments · Fixed by #3948
Assignees
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@stichbury
Copy link
Contributor

Description

The docs page on modular pipelines could use some ❤️ as it's hard to understand and doesn't tie back very well to what we've already discussed in the spaceflights tutorial.

It needs a solid review and update.

@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Nov 2, 2022
@stichbury stichbury self-assigned this Nov 2, 2022
@stichbury stichbury moved this to To Do in Kedro Framework Nov 14, 2022
@yetudada yetudada removed the status in Kedro Framework Nov 14, 2022
@merelcht
Copy link
Member

@stichbury What kind of changes do you have in mind? Let's add them here, so anyone in the team could work on this ticket.

@stichbury
Copy link
Contributor Author

@merelcht Sorry it's taken me so long to spot your question!

So I think the page at present doesn't really explain to the user why they may want to create a modular pipeline, nor what/how they do it.

I'd like to see it more like a tutorial that is based on the spaceflights starter (extends it). So we title the page something like "How to manage complex pipelines" because we can't be sure that everyone knows what a modular pipeline is.

How to manage complex pipelines

Introducing modular pipelines

Benefits of modular pipelines

Not marketing, but list each of the potential user problems and explain how the modular pipeline may solve them

Tutorial to create a modular pipeline

Detail goes here -- explain namespaces

How to share a pipeline

How to use a shared pipeline

FAQs

@stichbury
Copy link
Contributor Author

This is just a rough draft of how the page could look but gives an idea of how to rearrange what is there/add new materials

@astrojuanlu
Copy link
Member

Could we merge this with #2723 ?

@stichbury
Copy link
Contributor Author

Tempting! Ideally they need to be done together but the modular pipelines terminology discussion is a deeper one than the "fix the docs so they read better" task. That is; I'm pretty sure I could do the latter but I'm no way qualified to tackle the former #2723 without some further "training".

@astrojuanlu
Copy link
Member

astrojuanlu commented May 16, 2024

Since badly-named "modular pipelines" (for most practical purposes, a "pipeline" in Kedro framework is a modular pipeline) are still confusing (echoing @idanov comments on @ankatiyar's Tech Design session on kedro-airflow) I think it's time we take on this issue.

I have a very specific proposal:

In many typical Kedro projects, a single (“main”) pipeline increases in complexity as the project evolves. To keep your project fit for purpose, we recommend that you create modular pipelines, which are logically isolated and can be reused. Modular pipelines are easier to develop, test and maintain, and are portable so they can be copied and reused between projects.

to make it clear that "Modular pipelines" is the Kedro Framework take on how Pipeline objects should be wrapped and structured.

How does this sound?

@astrojuanlu
Copy link
Member

Reprioritising this as High.

@stichbury
Copy link
Contributor Author

I'm going to unsubscribe from this issue as I can't help much, but do tag me in later if you want a review of the finished docs. I would say, just as you've noted that you're reprioritising this, that you need to be sure it is an issue that's impacting sufficient people to warrant the time it'll take to unpick and detangle this. I know it's frustrating for the team, but is it confusing sufficient numbers of users at this point to be something you take on? If so, godspeed, and let me know when you're ready for a review!

@astrojuanlu astrojuanlu moved this to To Do in Kedro Framework May 29, 2024
@astrojuanlu astrojuanlu assigned DimedS and unassigned stichbury May 29, 2024
@DimedS DimedS moved this from To Do to In Progress in Kedro Framework May 29, 2024
@DimedS DimedS linked a pull request Jun 11, 2024 that will close this issue
7 tasks
@DimedS DimedS moved this from In Progress to In Review in Kedro Framework Jun 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants