Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert all special conversion logic in OmegaConfigLoader for DictConfig #2561

Closed
noklam opened this issue May 5, 2023 · 0 comments · Fixed by #2582
Closed

Revert all special conversion logic in OmegaConfigLoader for DictConfig #2561

noklam opened this issue May 5, 2023 · 0 comments · Fixed by #2582
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented May 5, 2023

Description

Short description of the problem here.

This is nearly there but I think there's a bug with it unless I'm missing something: what happens if you have a single parameters.yml file and want to use runtime_params?

As part of a separate PR I think we should revert #2378 (but keep test_no_DictConfig_in_store as it's a good regression test) and #2176.

As part of the conversation in #2467, we should revert the changes that we added in #2378 and #2176 as we no longer need to deal with the special DictConfig object. Historically we need that because OmegaConfigLoader return DictConfig instead of a primitive Dict.

We also need to keep the test to make sure there is no regression and #2357 will not happen again.

Context

How has this bug affected you? What were you trying to accomplish?

@merelcht merelcht changed the title Revert all special conversion logic for DictConfig Revert all special conversion logic in OmegaConfigLoader for DictConfig May 9, 2023
@noklam noklam moved this to To Do in Kedro Framework May 15, 2023
@noklam noklam self-assigned this May 15, 2023
@noklam noklam linked a pull request May 15, 2023 that will close this issue
5 tasks
@noklam noklam moved this from To Do to In Review in Kedro Framework May 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants