Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement our own uninstall() method for rich traceback or raise a PR upstream #2609

Closed
noklam opened this issue May 25, 2023 · 2 comments
Closed

Implement our own uninstall() method for rich traceback or raise a PR upstream #2609

noklam opened this issue May 25, 2023 · 2 comments
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@noklam
Copy link
Contributor

noklam commented May 25, 2023

Description

Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
See #2592.

Currently user need to set KEDRO_LOGGING_CONFIG to disable rich's traceback, because the default logging installed it and there is no way to uninstall it.

Context

Why is this change important to you? How would you use it? How can it benefit other users?
setting rich_tracebacks should disable traceback without using KEDRO_LOGGING_CONFIG

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.
@noklam noklam added the Issue: Feature Request New feature or improvement to existing feature label May 25, 2023
@astrojuanlu
Copy link
Member

Should we favour #2928 over this one?

@astrojuanlu
Copy link
Member

I think we should. I'm going to close this issue, but please if you disagree feel free to leave a comment.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrojuanlu @noklam