You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow-up ticket to update the documentation. Since there are many changes in logging, it makes sense to look at the whole logging documentation. Splitting this from #2642 since the PR is getting too large.
Some changes we made:
conf/base/logging.yml is optional
conf/base/logging.yml -> conf/logging.yml - it will is agnostic to environment
Logging is setup from the beginning - project logging is optional.
This could affect our logging.md and some of the deployment docs and more. The best way to do it is go through the RELEASE.md we have made in the last couple of months and check the closed milestone ticket
Checklist
update the documentation
Do a manual test to make sure everything work as expected. With/without logging.yml, using KEDRO_LOGGING_CONFIG etc.
This is a huge improvement, thank you! 🙏 I would recommend picking up #2520 next so then we've got all the logging code changes complete and then write the docs after that.
When it comes to writing docs, we should be able to make the page MUCH simpler. Basically it would be something like:
By default kedro, uses rich for logging. For the full setup, look at the default_logging.yml file
If you want to change this then make your own logging.yml file. We recommend you put that file in conf. Then set KEDRO_CONFIG_LOGGING environment variable to point to it
Show some of the things you might like to change and the code needed to do it:
a. Turn off rich tracebacks
b. Turn on file logging
c. Show DEBUG level messages
No need to explain the difference between framework-side and logging-side configuration or any of that confusing stuff any more 🎉
Description
This is a follow-up ticket to update the documentation. Since there are many changes in logging, it makes sense to look at the whole logging documentation. Splitting this from #2642 since the PR is getting too large.
Some changes we made:
conf/base/logging.yml
is optionalconf/base/logging.yml
->conf/logging.yml
- it will is agnostic to environmentKEDRO_LOGGING_CONFIG
env variable to specific where to read logging.yml #2535This could affect our
logging.md
and some of the deployment docs and more. The best way to do it is go through theRELEASE.md
we have made in the last couple of months and check the closed milestone ticketChecklist
logging.yml
, usingKEDRO_LOGGING_CONFIG
etc.logging
from ConfigLoader #2642 and Make sure project logs of INFO level are shown #2520Also this:
Follow-up
The text was updated successfully, but these errors were encountered: