-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starters to use new /conf structure #2753
Comments
What goes in Feel like it's these are "hard" questions to know what to do, especially as a newer user. Apologies if this was already discussed/clear. |
The scope of this is replacing
with
so, no new complexity or indirection is added, we just make the file hierarchy more flat. You raise a good point but that's not what we are intending to solve here, I'd say. @amandakys correct me if I'm wrong. |
@astrojuanlu to clarify in the current state the
In the structure proposed in this ticket, it is expected for all non pipeline specific parameters and catalog entries to go in the non pipeline specific
To your point about complexity @deepyaman - I don't think this introduced any ambiguity that doesn't already exist as users are currently free to define the scope of their catalog files. The behaviour of For new users in particular, the source of confusion being that they would be unsure as to where to put catalog entries is potentially minimised as it introduces the concept of pipeline-specific separation. The extant default would be to place all their catalog entries into Alternatively we could continue with the trend of not providing platform specific catalog files upon creating a new pipeline. In which case we would only provide the |
Quick comment on one of the points:
I'd be -1 on that, since it can create ambiguity with a pipeline called |
I'm going to vote on continuity over consistency here. I agree splitting catalog files puts them at the same level as parameters, which increases consistency and informs users that they can do such a thing. But I also agree with @deepyaman and @yetudada that it might create confusion for arguably the most important file of the whole project. On top of that, we were not creating separate catalog files before, so by continuing to use a "global" one by default, we keep the same behavior. |
I discovered that currently, we have only one starter (spaceflights) that contains a 'parameters' folder with two pipeline_name.yml files inside. There are no starters with a catalog folder. So, it seems that we only need to move and rename the two spaceflights YAML files. |
Description
We want to update the new /conf folder structure to look like
with separate catalog and parameters files for each pipeline in the project
rather than
This change needs to be made across the starters
This is a follow up on the work to update the
kedro pipeline create
command #2752The text was updated successfully, but these errors were encountered: