Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when using a catch-all pattern with dataset factories #2760

Closed
ankatiyar opened this issue Jul 3, 2023 · 1 comment
Closed
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@ankatiyar
Copy link
Contributor

Description

Users can register default datasets with dataset factories (#2423) by adding a catch-all pattern:

"{default}":
  filepath: data/01_raw/{default}.csv
  type: CSVDataSet

Add a warning when this is catch-all pattern is used.

Context

From User research #2602

2. There should be a warning about the catch-all pattern that replaces default dataset creation

5 users mentioned this explicitly:

"if you did a dataset that replaced all the memory dataset, would we get like a warning or an error or something?"

"Maybe it'll be nice to, for users if they define something like that, to give them like warning or even to give them a prompt that they made or ask them if it's, if it's expected. Because I guess that that will be the, the first mistake everyone makes when they start working with the feature."

@ankatiyar ankatiyar added the Issue: Feature Request New feature or improvement to existing feature label Jul 3, 2023
@ankatiyar
Copy link
Contributor Author

Closed by #2774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
Archived in project
Development

No branches or pull requests

1 participant