Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OmegaConfigLoader the default config loader #2949

Closed
merelcht opened this issue Aug 18, 2023 · 2 comments
Closed

Make OmegaConfigLoader the default config loader #2949

merelcht opened this issue Aug 18, 2023 · 2 comments
Assignees
@ankatiyar
Labels
Component: Configuration
Milestone
Breaking config l...

Comments

@merelcht
Copy link
Member

merelcht commented Aug 18, 2023 •
edited
Loading

Description

The ConfigLoader and TemplatedConfigLoader will be removed in #2692, so the new default should be OmegaConfigLoader.

To be decided

We could either do this in the 18 series before the ConfigLoader and TemplatedConfigLoader are removed or do it as part of 0.19.0.
@astrojuanlu
Copy link
Member

I feel like changing the default could be seen as a breaking change? So I'm voting to do it for 0.19.0.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@merelcht merelcht moved this to To Do in Kedro Framework Oct 25, 2023
@ankatiyar ankatiyar moved this from To Do to In Progress in Kedro Framework Oct 30, 2023
@ankatiyar ankatiyar mentioned this issue Oct 30, 2023
Merged
7 tasks
@ankatiyar ankatiyar moved this from In Progress to In Review in Kedro Framework Oct 30, 2023
@ankatiyar
Copy link
Contributor

closed by #3243

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankatiyar ankatiyar

Labels
Component: Configuration
Projects
Kedro Framework
Archived in project
Milestone
Breaking config loader changes
Development

No branches or pull requests
3 participants
@astrojuanlu @merelcht @ankatiyar