Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation notice to signal the archiving of starters + new project creation flow #3114

Closed
Tracked by #3123
merelcht opened this issue Oct 3, 2023 · 2 comments · Fixed by #3173
Closed
Tracked by #3123
Assignees
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro

Comments

@merelcht
Copy link
Member

merelcht commented Oct 3, 2023

Description

In Kedro 0.19.0 we're removing some of the starters and introducing a completely new project creation flow. We should add warnings/info to our users ahead of this so they know this flow will change.

Context

Possible Implementation

  • Add a temporary message in the kedro new flow that explains the changes that are coming.
  • Updatekedro starter list and add (deprecated/archived) to the starters that will be archived in Archive "non-unique" starters #3113
@merelcht merelcht added the Issue: Feature Request New feature or improvement to existing feature label Oct 3, 2023
@merelcht merelcht added Component: CLI Issue/PR that addresses the CLI for Kedro and removed Issue: Feature Request New feature or improvement to existing feature labels Oct 3, 2023
@merelcht merelcht changed the title Add a deprecation notice to signal the removal of starters + new project creation flow Add a deprecation notice to signal the archiving of starters + new project creation flow Oct 9, 2023
@ankatiyar ankatiyar moved this to To Do in Kedro Framework Oct 12, 2023
@ankatiyar ankatiyar self-assigned this Oct 12, 2023
@ankatiyar ankatiyar moved this from To Do to In Review in Kedro Framework Oct 13, 2023
@astrojuanlu
Copy link
Member

Bringing here some concerns that @datajoely raised on #3173:

So I want to strongly argue we shouldn't delete the empty pyspark starter- the verticals need any empty template to build off

We would be archiving the old starters and not removing them, so as far as I understand Kedro 0.18 with the old starters will keep working for the time being. Are we missing something?

can you follow all the add on steps from a single command?

Again, as far as I understand, the plan is to make the kedro new commands have CLI flags so that it's possible to completely skip the interactive flow #3054 (comment)

when a flag isnt chosen, the user will go through those steps of the interactive flow

(and by omission, when all flags are chosen, no interactive flow will appear)

More broadly, this breaking change will require downstream projects to adapt to the new way, but we think the end result is going to be superior to what we have nowadays. Please let us know your thoughts on this thread.

@datajoely
Copy link
Contributor

datajoely commented Oct 13, 2023

Apologies for linking internal, hopefully this is all open early next year

So if you look at how an alloy app is configured here, Alloy retrieves the cookiecutter template directly

https://brix.quantumblack.com/products/alloy/docs/01_intro/key_concepts/#app

If you drop this from 0.19.x there will be barrier for Verticals adopting the latest version of Kedro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants