-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-987] Current kedro_cli behaviour should be in main kedro package #314
Comments
@seeM Thank you for raising this! We have a ticket to do this actually, but haven't had a chance to implement it yet. We will let you know once the clean-up in kedro-cli.py is done. |
Amazing, thank you! 😄 |
@seeM I completely agree. I have gone as far as removing the cli completely from our project template to make it easier to keep them up to date. If I remember right it was pretty much copying the existing cli into a library, then importing cli inside each project. This reduced it from ~600 lines to about 3, and if a project still wants to add a special cli command they are welcome to as the cli object is right there to add onto. Now I have only one cli to keep up to date rather than dozens. |
@921kiyo is currently making this change for our next release! Stay tuned 😄 |
The new kedro versions (0.16.*) have a lot of the CLI functionality moved to the library side. We left only functionality related to |
Thanks @921kiyo @yetudada @lorenabalan for handling this so well 😄 |
Description
The current auto-generated
kedro_cli.py
should be mostly internal to thekedro
package, and thinly wrapped in the project'skedro_cli.py
, for example, an import and a function call.Context
One of the main purposes of a framework is to reduce duplication and boilerplate. The
kedro_cli.py
files are ~600 lines of code that don't really have anything to do with project-specific behaviour – they are essentially boilerplate.Django has a similar setup with its
manage.py
importing and calling theexecute_from_command_line
function.The text was updated successfully, but these errors were encountered: