Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kedro ipython for the debugging line magic #3536

Closed
Tracked by #3535
noklam opened this issue Jan 19, 2024 · 0 comments · Fixed by #3604
Closed
Tracked by #3535

Support kedro ipython for the debugging line magic #3536

noklam opened this issue Jan 19, 2024 · 0 comments · Fixed by #3604
Assignees
Labels
Component: Jupyter/IPython Issue/PR relevant for Jupyter Notebooks, IPython sessions and the interactive workflow in Kedro

Comments

@noklam
Copy link
Contributor

noklam commented Jan 19, 2024

Context

Currently it only support notebook/lab. Add support for IPython, it should also work with kedro ipython.

But I agree, ipython version, since you're likely in your IDE, no need to bring in the function body. You can open the right file and dev there
HI. very nice! is it something that could work in kedro ipython also direclty ?

It may works slightly different in IPython because it doesn't have the concepts of "cell". Most likely it will be just one big chunk of code, optionally we may exclude the "function body" because it's less useful in this context and most likely user are working with an IDE (e.g. VSCode or Pycharm Python terminal). The developer who pick this up will need to make some decision what format would make most sense and provide better experience for users.

Implementation

  • get_ipython().set_next_input(s) might be useful for copying the node code into the notebook.

Most of the structure is already implemented in #3510, so we should instead spend more time on thinking what make most sense when working in a IDE/terminal and how would that experience be like. Try to do the same thing with a debugger, how would you put a breakpoint if you suspect a specific dataset is corrupted, what would that process be like?

@merelcht merelcht moved this to To Do in Kedro Framework Jan 22, 2024
@merelcht merelcht added the Component: Jupyter/IPython Issue/PR relevant for Jupyter Notebooks, IPython sessions and the interactive workflow in Kedro label Jan 22, 2024
@lrcouto lrcouto moved this from To Do to In Progress in Kedro Framework Feb 8, 2024
@noklam noklam moved this from In Progress to In Review in Kedro Framework Feb 13, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Jupyter/IPython Issue/PR relevant for Jupyter Notebooks, IPython sessions and the interactive workflow in Kedro
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants