Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent navigation links in documentation #3709

Closed
astrojuanlu opened this issue Mar 13, 2024 · 0 comments · Fixed by kedro-org/kedro-sphinx-theme#19
Closed

Inconsistent navigation links in documentation #3709

astrojuanlu opened this issue Mar 13, 2024 · 0 comments · Fixed by kedro-org/kedro-sphinx-theme#19
Assignees
@ravi-kumar-pilla
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@astrojuanlu
Copy link
Member

astrojuanlu commented Mar 13, 2024 •
edited by merelcht
Loading

Description

Our documentation has inconsistent navigation links. Sometimes we point to "/stable" sometimes to nothing.

Context

Also spotted by @noklam

kedro/docs/source/_templates/layout.html

Lines 14 to 15 in 1f2adf1

<a href="https://docs.kedro.org/projects/kedro-viz/en/stable/">Kedro-Viz</a>
<a href="https://docs.kedro.org/projects/kedro-datasets">Kedro-Datasets</a>

Notice that now we have this problem in 3 different repos, as per #3586.

Implementation

Update all links to point to "nothing", so remove the "/en/stable" or "/stable" part from the links.
@astrojuanlu astrojuanlu added Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed labels Mar 13, 2024
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@ankatiyar ankatiyar added the Hacktoberfest Issue suitable for hacktoberfest label Sep 30, 2024
@merelcht merelcht removed the Hacktoberfest Issue suitable for hacktoberfest label Nov 26, 2024
@ravi-kumar-pilla ravi-kumar-pilla self-assigned this Jan 6, 2025
@ravi-kumar-pilla ravi-kumar-pilla mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravi-kumar-pilla ravi-kumar-pilla

Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
No open projects
🎃 Hacktoberfest 🎃
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove inconsistent navigation links in documentation kedro-org/kedro-sphinx-theme
4 participants
@astrojuanlu @merelcht @ravi-kumar-pilla @ankatiyar