Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple starters from framework in tool selection flow #3791

Open
merelcht opened this issue Apr 8, 2024 · 0 comments
Open

Decouple starters from framework in tool selection flow #3791

merelcht opened this issue Apr 8, 2024 · 0 comments

Comments

@merelcht
Copy link
Member

merelcht commented Apr 8, 2024

Description

With the addition of the tools flow some coupling between framework and the starters was added in the post_gen_project scripts: see https://github.com/kedro-org/kedro-starters/blob/main/spaceflights-pyspark/hooks/post_gen_project.py

Unit tests for the tools selection have become hard to maintain see e.g. #3594, because framework needs to pull the starters. If we can somehow decouple the tools selection process better the tests might become simpler too.

Context

See #3594 (comment)

Possible Implementation

The checks here: https://github.com/kedro-org/kedro-starters/blob/main/spaceflights-pyspark/hooks/post_gen_project.py#L30 shouldn't be needed because at this point the tool selection should already have been checked and verified on the Kedro side. This might mean we can move the main function to Kedro.

@merelcht merelcht added Issue: Feature Request New feature or improvement to existing feature and removed Issue: Feature Request New feature or improvement to existing feature labels Apr 8, 2024
@merelcht merelcht added this to the Project tools follow up milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant