Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure blob requires fsspec >= 0.8 and kedro is still on 0.7 #597

Closed
Lucianois opened this issue Nov 4, 2020 · 5 comments
Closed

Azure blob requires fsspec >= 0.8 and kedro is still on 0.7 #597

Lucianois opened this issue Nov 4, 2020 · 5 comments
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@Lucianois
Copy link
Contributor

Lucianois commented Nov 4, 2020

Description

Azure blob with authentication via Shared Access Signature requires fsspec >= 0.8

Context

Kedro install does not compile, kedro viz does not work with fsspec 0.8

Steps to Reproduce

  1. pip install -U fsspec
  2. pip install adlfs
  3. kedro run ( with azure blob dataset)

Expected Result

load data from Azure blob storage

Actual Result

  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/lucianoissoe/opt/anaconda3/lib/python3.7/site-packages/adlfs/__init__.py", line 1, in <module>
    from .spec import AzureDatalakeFileSystem
  File "/Users/lucianoissoe/opt/anaconda3/lib/python3.7/site-packages/adlfs/spec.py", line 21, in <module>
    from fsspec.asyn import (
ModuleNotFoundError: No module named 'fsspec.asyn'
kedro.io.core.DataSetError: 
No module named 'fsspec.asyn'.
Failed to instantiate DataSet 'safras' of type `kedro.extras.datasets.pandas.csv_dataset.CSVDataSet`.
Error: 
No module named 'fsspec.asyn'.
Failed to instantiate DataSet 'safras' of type `kedro.extras.datasets.pandas.csv_dataset.CSVDataSet`.

Your Environment

Include as many relevant details about the environment in which you experienced the bug:

  • Kedro version used (pip show kedro or kedro -V):kedro, version 0.16.6
  • Python version used (python -V):Python 3.7.6
  • Operating system and version: Mac
@Lucianois Lucianois added the Issue: Bug Report 🐞 Bug that needs to be fixed label Nov 4, 2020
@Lucianois
Copy link
Contributor Author

this may be a duplicate from #489 and expected to be fixed in 0.17

@Minyus
Copy link
Contributor

Minyus commented Nov 4, 2020

I wouldn't say this is a duplicate.

Despite the #489 comment, as of 4th Nov 2020, https://github.com/quantumblacklabs/kedro/blob/develop/requirements.txt#L5 sets fsspec>=0.5.1, <0.8, which means that current develop branch does not support fsspec >= 0.8 and cannot solve this Azure blob issue.

PyTorch Lightning also requires fsspec>=0.8 and got the same problem: #553

@turn1a
Copy link

turn1a commented Nov 5, 2020

s3fs also, please update.

@lorenabalan
Copy link
Contributor

Hi @Lucianois thanks for raising this. We are aware this is really inconvenient, but it will be made available in version 0.17.0. Commit 151cbcd was pushed to develop branch.

@lorenabalan
Copy link
Contributor

Closing this as resolved (in light of comment above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants