Add docs about using env vars for credentials with OmegaConfLoader
#2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
force-pushed
the
docs/env-variables-for-credentials
branch
from
24a87fd to
7d8bd4d
Compare
merelcht
requested review from
stichbury and
jmholzer
and removed request for
yetudada
|
Can you do non-credentials too? I'm sure people will want to override |
No. In the interviews we did about config loaders the majority of the users that make use of environment variables in Kedro projects said they use them to store credentials. Environment variables shouldn't be used an abused all over the place, so if we decide to add more support for them we'd have to first find out what valid use cases apart from credentials exist. |
stichbury
reviewed
Jan 25, 2023
stichbury
approved these changes
Jan 25, 2023
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
jmholzer
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs to follow up #2178
Checklist
RELEASE.mdfile