Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement a way for visual component to communicate with LSP #56

Closed
Tracked by #58 ...
noklam opened this issue Aug 4, 2024 · 2 comments
Closed
Tracked by #58 ...
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented Aug 4, 2024

Two possible solutions:

  1. Through the lspClient sendRequest method, we will need to create those request manually.
  2. Create a VSCode command and using callback to trigger the command.
@noklam
Copy link
Contributor Author

noklam commented Aug 13, 2024

I have experimented with the Command approaches, it didn't trigger the Go To definition properly.

image

Request/Response usually comes with a pair, but now we basically want to do this

  1. Send request Execute command
  2. Send Response with a "TextDocument/Definition" type

I will continue to explore if this approaches work. The benefit of this is we can keep most of the logic in Python and make use of the pygls library.

Backup plan for this is actually sending a proper "TextDocument/Definition" request from the frontend and handle the logic with specific paramaters that Kedro LSP would understand.

@noklam noklam self-assigned this Aug 13, 2024
@noklam
Copy link
Contributor Author

noklam commented Aug 13, 2024

command-request
I implemented a PoC here, in the final integration we don't need the command but it's useful for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant