CLOB and BLOB columns are not filled

[toao]

Hi @keeguon ,
it seems that CLOB and BLOB columns are currently not properly handled: instead of the actual data empty_clob() is passed instead which leads to empty entries.

I've put an example into the related issue in the main gem: zdennis/activerecord-import#637 (comment)

[keeguon]

@toao wow, totally missed that notification truly sorry, will take a look over the week.

[keeguon]

@toao I took a look and it seems it's coming from the adapter itself misbehaving when quoting values of *LOB columns as you can see here : https://github.com/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced/quoting.rb#L77-L92.

Apparently some people have reported this behavior in the past here : rsim/oracle-enhanced#1588 and have solved it by casting the value directly in the SQL statement but handling it in this "activerecord-import" extension seems it could have other consequences and could be costly cause we would have to iterate over the value set and check the type in the DB for each column to call the cast function which is kind of out of the scope of the original gem.

[toao]

@keeguon thanks for the feedback and having a look. meanwhile we patched it ourselves and using a fork in our project. it's not pretty but it works 😉

There's also an additional problem with to_clob() not being able to handle any length/size of a string, so the data has to be split in chunks and afterwards joined again within the SQL statement.

here's what we changed: toao/oracle-enhanced@9da904a...toao:2db0fb62fefe34e70fee29583eeaf19face7ca44

I guess this issue can be closed then, as it has to be fixed directly in oracle-enhanced instead.