Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Labels with Dataviz() #309

Closed
aegbertjr opened this issue Aug 2, 2015 · 3 comments
Closed

Override Labels with Dataviz() #309

aegbertjr opened this issue Aug 2, 2015 · 3 comments

Comments

@aegbertjr
Copy link

Hello,

I love the Keen Dashboards. I have noticed my labels stopped overriding some time after version 3.2.3. I verified that if I dial my version back to 3.2.3 the following still overrides my labels as expected:

'''
theChart = new Keen.Dataviz()
.el(document.getElementById('conversion-chart'))
.chartType('columnchart')
.labels(['A', 'B', 'C'])
.chartOptions({
legend: { position: 'none' },
orientation: 'horizontal'
})
.width(800)
.height(300)
.prepare();
'''

Perhaps related to: #299

@aegbertjr
Copy link
Author

...probably worth nothing that this is for a funnel.

@dustinlarimer
Copy link
Contributor

Hey, @aegbertjr – this was patched back up (#299) and clarified in v3.2.6:
Release: https://github.com/keen/keen-js/releases/tag/v3.2.6
Docs: https://github.com/keen/keen-js/tree/master/docs/dataviz#labelsarray

Would you mind upgrading and letting me know if the problem persists? Thanks!

@aegbertjr
Copy link
Author

Thanks for the response! It came down to the order of execution....thanks for taking the time to push me to the link. I will close!

Important note about .labels() (Dataviz): this method must be called after .data(), .parseRequest(), or .parseRawData(), and before .render() to take effect. This method executes a one-time, permanent modification of the underlying Dataset instance, and will be overwritten every time the chart consumes new data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants