Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IE 6/7 #316

Closed
vebinua opened this issue Aug 10, 2015 · 2 comments
Closed

Support for IE 6/7 #316

vebinua opened this issue Aug 10, 2015 · 2 comments

Comments

@vebinua
Copy link

vebinua commented Aug 10, 2015

I'm running keen over IE7 and apparently this js error pop-ups on page load: http://screencast.com/t/PVI1foNTZm13, and references the keen.io library (https://d26b395fwzu5fz.cloudfront.net/3.2.6/keen.js)
"Error Message: Expected identifier, string or number"

*which points to the following line: http://screencast.com/t/o13Iw8PX (#3190, not minified)

There's a misplaced comma in that object definition which IE6/7, don't automatically fix.

**Fixing the above issue, leads to another one:
"JSON is undefined" error message. Here's a snapshot: http://screencast.com/t/HzaCgxp8sx

Since the library uses JSON.stringify function, it will need to include the JSON3 parser in order to support it on IE < 8.

I added reference to JSON3 (//cdnjs.cloudflare.com/ajax/libs/json3/3.3.2/json3.min.js) on top of the keen library.js and that fixes it.

Wish you could have this added/compiled, or if you could guide me how- That'll be really great!

@dustinlarimer
Copy link
Contributor

Thanks for digging into this @vebinua! I've opened two issues to track each of these. I appreciate your help!

@vebinua
Copy link
Author

vebinua commented Aug 11, 2015

You are very welcome @dustinlarimer! and Thank you too. Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants