Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve tests of decrease_position_utils library. #487

Open
sparqet opened this issue Oct 4, 2023 · 4 comments
Open

test: Improve tests of decrease_position_utils library. #487

sparqet opened this issue Oct 4, 2023 · 4 comments
Labels
enhancement New feature or request testing

Comments

@sparqet
Copy link
Collaborator

sparqet commented Oct 4, 2023 •
edited
Loading

Description

Implement and improve tests of decrease_position_utils library.

File: test/position/decrease_position_utils.cairo.

Acceptance criteria

  • Unit tests (nominal and failure) are implemented and passing.
@sparqet sparqet added enhancement New feature or request testing labels Oct 4, 2023
@sparqet sparqet changed the title test: Improve tests of decrease_position_utils library. test: Improve tests of decrease_position_utils library. Oct 4, 2023
@ametel01
Copy link
Contributor

ametel01 commented Oct 6, 2023

Happy to take this

@sparqet
Copy link
Collaborator Author

sparqet commented Oct 7, 2023

Of course !

@Sk8erboi84
Copy link
Collaborator

Any updates ? @ametel01

@ametel01
Copy link
Contributor

There is a nasty bug somewhere: [ERROR] Failed setting up runner. that is taking longer than expected to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sparqet @ametel01 @Sk8erboi84