-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolock the vault when macOS session is locked #231
Comments
Thanks! I will look into this. |
@keepassium, honestly, this can be considered a security issue for the following reasons:
Could you consider prioritising this please? |
@vit9696 , I agree, this can be considered a security issue. It's just I did not focus on the Mac version too much so far. This looked simple enough so I went ahead and implemented the database and app lock. However, this must be optional (many people close/open the lid every few minutes in a safe/trusted environment.) And that option is for Mac only. So I'll need to rewrite the settings UI to make it dynamic and hide irrelevant options in mobile version. And that will take some time… |
On a second thought, this does not have to be a separate option. Screen locking/unlocking on a Mac can be wired just as app activation/deactivation on iOS. This way, it would simply work with the existing timeouts, no need for additional UI. For instance, setting the App Lock timeout to "immediately" would lock the app when you close the lid. If the timeout is set to something longer, the app would check the time on screen unlock, and act accordingly (just like it does on iOS). Same for database timeouts. |
Hmmm, personally I would prefer on iOS it to work the same way it does on macOS, but I am unsure it is possible. I.e. when I press the power button on my phone or my tablet, I would like the thing lock. Yet, when I simply switch to another app I would rather it not lock, because I can be copying some valuable information from one field and may want to return for another field. If this is not possible, locking the app immediately when switching to another app can be a temporary solution till a better API is available on iOS side. |
I guess it does, @keepassium! This is exactly how I use KeePassium on iOS, with “immediately” selected. |
Thanks! So I have routed screen locking/unlocking as app activation/deactivation events. This will be in the next update, and we'll iterate and refine from there, if needed. |
@keepassium, I think it does not quite work the way it was changed in the latest update and is now totally broken.
In my opinion, besides fixing (3), on macOS screen lock should lock the database at any database locking timeout. I.e. regardless of the setting. |
What can be improved?
I noticed that even fiddling with Control Access options, there's no option (AFAIK) to lock the vault when I suspend the session (close the lid, block it manually with
Command + Control + Q
, or macOS shows screensaver or enters sleeping mode). Some other apps, like KeePassXC and MacPass, have this option, and I find it valuable so if someone bypass my macOS password/login, they still won't be able to access my passwords. (When I'm using the computer, I usually leave Keepassium opened/vault unlocked for convenience.)The solution you'd like
An extra option to lock the vault whenever the session is locked.
The text was updated successfully, but these errors were encountered: