Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popup when things change immediately #76

Open
rugk opened this issue Mar 14, 2018 · 8 comments · May be fixed by #2347
Open

Update popup when things change immediately #76

rugk opened this issue Mar 14, 2018 · 8 comments · May be fixed by #2347
Labels
feature request PR pending A pull request for this feature or fix has been made

Comments

@rugk
Copy link

rugk commented Mar 14, 2018

Steps to Reproduce (for bugs)

E.g.:

  1. Go to a site, where you need to click "redetect login fields".

Expected Behavior

Directly after that, the popup should change.

Current Behavior

To input the password from the popup, I need to close it and reopen it. Only then the list of passwords appears there.

Just FYI: this issue is not new, it was already there with the old keepasshttp.

Possible Solution

Debug info

KeePassXC-Browser Version: 1.0.1
KeePassXC Version: 2.3.1
Operating system: Linux
Browser: Firefox
Proxy used: yes

@varjolintu
Copy link
Member

Thanks for reporting this. It’s time to get fixed.

@varjolintu varjolintu added the bug label Apr 1, 2018
@varjolintu
Copy link
Member

Any site you know where this happens every time?

@rugk
Copy link
Author

rugk commented Apr 2, 2018

This happens every time, independently of the site. It seems as of the update is just not implemented.

@rugk
Copy link
Author

rugk commented Apr 2, 2018

It also happens for the "reconnect" button BTW. There it should also (probably display a loading indicator, see other issue) and then directly update the pop-up.

@varjolintu
Copy link
Member

This is not an easy task with the current implementation. I changed this to a wishlish item so I can do some improvements in the future.

@varjolintu varjolintu added wishlist and removed bug labels Apr 7, 2018
@rugk
Copy link
Author

rugk commented Jun 15, 2018

I think this is done, is not it?

@varjolintu
Copy link
Member

Nope. The popup still doesn't change dynamically if you keep it open. At least there has been no fixes to this.

@varjolintu
Copy link
Member

Reminder for myself concerning this issue: Maybe the whole popup stuff could be replaced with a background script that holds and handles the popup status. In the optimal case there should be only one popup HTML and JS file, just for displaying stuff based on the current status. Anything extra could be handled in the background script(s).

@varjolintu varjolintu linked a pull request Sep 22, 2024 that will close this issue
@varjolintu varjolintu added the PR pending A pull request for this feature or fix has been made label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request PR pending A pull request for this feature or fix has been made
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants