Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser integration: KeePassXC icon/auto-populate appears in all fields in webapp (Synology) #2404

Open
LbqpdL opened this issue Dec 9, 2024 · 8 comments

Comments

@LbqpdL
Copy link

LbqpdL commented Dec 9, 2024

Overview

Hello,
I'm using KeepassXC browser integration to log into the web interface of my Synology NAS.
Once logged, KeepassXC icons will appear on all kinds of fields and propose to populate the field, even if it's not a login/password field.

Steps to Reproduce

  1. Setup KeepassXC with Web integration
  2. Autorise auth information to be inserted in the page
  3. The auth information are pushed to all fields

Expected Behavior

Only propose auth information at login page and / or on login/password fields

Actual Behavior

The auth information are pushed to all fields

Context

This mostly applies within a specific web application (admin portal of Synology NAS)

In the following screenshot:

Image
KeepassXC browser integration tries to populate the first field (the field is for an IP address)
The icon appears in the "repertoire" field and auto-populates it with a login (the field is for a text entry, a directory)

KeePassXC - Version 2.7.9
Révision : 8f6dd13

KeePassXC - Version 2.7.9
Révision : 8f6dd13

Qt 5.15.11
Le mode débogage est désactivé.

OS : Windows 11 Version 2009
Architecture : x86_64
Kernel : winnt 10.0.22631

Extensions activées :

  • Saisie automatique
  • Intégration aux navigateurs
  • Clés d'accès
  • Agent SSH
  • KeeShare
  • YubiKey
  • Déverrouillage rapide

Bibliothèques cryptographiques :

  • Botan 3.1.1
@LbqpdL LbqpdL added the bug label Dec 9, 2024
@droidmonkey droidmonkey transferred this issue from keepassxreboot/keepassxc Dec 9, 2024
@varjolintu varjolintu removed the bug label Dec 9, 2024
@varjolintu
Copy link
Member

varjolintu commented Dec 9, 2024

Is there a demo page or a public instance where this can be tried? There's two more open issues where Synology is mentioned.
At least it would be helpful to get the HTML code of those fields that are incorrectly detected.

@droidmonkey
Copy link
Member

I have a synology NAS and didn't notice any errant KeePassXC icons anywhere in the dialogs. I think I have a different software than the OP though.

@LbqpdL
Copy link
Author

LbqpdL commented Dec 12, 2024

Is there a demo page or a public instance where this can be tried? There's two more open issues where Synology is mentioned. At least it would be helpful to get the HTML code of those fields that are incorrectly detected.

You can create a demo environment via https://demo.synology.com

@droidmonkey
Copy link
Member

droidmonkey commented Dec 12, 2024

What is the exact portion of the admin console that shows this problem? Your screenshot was not specific and I don't understand the language.

Edit: looks like the backup screen

@varjolintu
Copy link
Member

And how do I get to the backup screen without any prompts or activations?

@LbqpdL
Copy link
Author

LbqpdL commented Dec 12, 2024

Sorry for the language.

You can spin up a demo in english at https://demo.synology.com/en-uk

You can dismiss the first screen (2FA auth) by clicking any link in black/underlined ("Non merci" in this screenshot)
Image

You can dismiss the second screen by doing the same then OK.

You can then select the displayed language in the top right corner by clicking on "personnal"
Image

And then select "english" as displayed language
Image

You can then open the "control panel"
Image

Within control panel, select "shared folder"
Image

Then dropdown menu "Create > create", this will launch the creation of a shared folder
Image

Shared folder creation wizard : Screenshot from the Demo instance
Image

Shared folder creation wizard : Screenshot from my personnal instance (with keepassxc browser integration activated)
When clicking in the first field, the auto-complete is proposed :
Image

Same for the second field
Image

This also happens in unrelated fields, such as a "filter" field

Screenshot from demo instance
Image

Screenshot from personnal instance
Image

This is how the entry is configured within the keepassxc database
Image

@LbqpdL
Copy link
Author

LbqpdL commented Dec 12, 2024

To further help the debugging, I tested from another browser (Chromium)

Keepass integration activated, not yet configured:
Image

If I connect manually (without connecting the extention to the database), I have the following:
Image

After connecting the extension, the password entry is recognised
Image

I de-log, and relaunch the login page. I then need to activate the "add option of Username only for the site"
Image

The login field is recognised (icon appears), I can log into the system
Image

This works as intended
Image

In the next screen, the password is then proposed for autologin
Image

Once logged-in, the issue appears
Image

@varjolintu
Copy link
Member

varjolintu commented Dec 22, 2024

Thanks for providing the instructions. I tested this and it seems the culprit is the Username-only Detection. It cannot distinquish the single input fields from fields like name, which is one reason we keep the option disabled by default. It can give too much false positives.

My suggestion is:

  • Disable the Username-only Detection for the site.
  • When you are on the login screen, choose Custom Login Fields from the popup and select the username field as such.
  • Do the same on the next screen for the password field.

In this way you can get the login dialog working without needing to enable the Username-only Detection that seems to have negative effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants