Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entry not possible if search is 'active' #895

Closed
DKX47 opened this issue Aug 24, 2017 · 6 comments · Fixed by #1398
Closed

New entry not possible if search is 'active' #895

DKX47 opened this issue Aug 24, 2017 · 6 comments · Fixed by #1398
Assignees
Milestone

Comments

@DKX47
Copy link

DKX47 commented Aug 24, 2017

When you searched via search bar, it's not possible to add new entries until you clear the search results (doesn't matter if you got any results). Is this somehow intended?

Expected Behavior

Allow adding new entries even if a search is active.

Current Behavior

"Add new entry" button is greyed out.

Debug Info

KeePassXC - Version 2.2.0
Revision: caa49a8

Bibliotheken:

  • Qt 5.7.1
  • libgcrypt 1.7.8

Betriebssystem: Fedora 26 (Workstation Edition)
CPU-Architektur: x86_64
Kernel: linux 4.12.5-300.fc26.x86_64

Aktivierte Erweiterungen:

  • KeePassHTTP
  • Auto-Type
  • YubiKey
@droidmonkey
Copy link
Member

This is intentional. Press escape to cancel the search or hit the x button.

@DKX47
Copy link
Author

DKX47 commented Aug 24, 2017

OK. May I ask why?

@droidmonkey droidmonkey reopened this Aug 25, 2017
@droidmonkey
Copy link
Member

I can't think of a specific one come to think of it besides group scope. I'll give this a looksie.

@droidmonkey droidmonkey self-assigned this Aug 25, 2017
@droidmonkey droidmonkey added this to the v2.3.0 milestone Oct 22, 2017
@spaetz
Copy link

spaetz commented Nov 1, 2017

Thanks for considering to "fix" this. Let me add that there is no issue with group scope. When searching, you are still within a specific group and hitting the "add" button will lead to no surprises.

As for the use case:
I often start searching for an entry on an open web site and noticing that there is none yet, I want to create a new one. Not being able to just hit "add" but having to clear the search before is an additional and IMHO unnecessary step.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Nov 1, 2017

I often start searching for an entry on an open web site and noticing that there is none yet, I want to create a new one.

I was thinking about this when using keepassxc myself.

Creating a new entry while searching should set the new entry Title to the search text.

Ex: I search for Github, no entry available, I press Add Entry, the entry Title is automatically set to Github

@DKX47
Copy link
Author

DKX47 commented Nov 5, 2017

That would be really convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants