Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick unlock issue when TouchID was used before #9032

Closed
2 tasks done
GoTTi74 opened this issue Jan 26, 2023 · 1 comment · Fixed by #9034
Closed
2 tasks done

Quick unlock issue when TouchID was used before #9032

GoTTi74 opened this issue Jan 26, 2023 · 1 comment · Fixed by #9034

Comments

@GoTTi74
Copy link

GoTTi74 commented Jan 26, 2023

Overview

When I open a DB with my MacBook lid opened, TouchID is enabled. I can unlock the DB only when the TouchID is available (lid open). However, when the TouchID is unavailable (lid closed) and I press "Cancel" in the unlock screen nothing happens. In previous versions the "Cancel" button was working and I could enter the master password.

Steps to Reproduce

PreRequisites:

  • MacBook with TouchID
  • External monitor, keyboard and input device (mouse, trackpad, etc.)

Preferences / Security Settings

  • "Enable database quick unlock"
  • "Lock database when session is locked or lid is closed"

Steps:

  1. Open a DB with the lid opened
  2. Lock the DB
  3. Close the lid
  4. KeePassXC shows the (TouchID) unlock screen with "Unlock and Cancel" buttons.

Actual Behavior

Pressing "Cancel" doesn't do anything (see screen recording)
Pressing "Unlock" certainly causes an error because the TouchID is disabled while the lid is closed.
https://user-images.githubusercontent.com/34171603/214972955-3e434cee-6f50-4d64-bdcc-f25b062ce5cd.mp4

The only workaround is to either close the DB and re-open it or to open the lid and unlock the DB

Expected Behavior

When clicking "Cancel" the default "Unlock Database" screen should come up where you can enter the master password
Note: With previous versions the "Cancel" button did work as expected.

KeePassXC - Version 2.7.4
Revision: 63b2394
macOS 12.6.2 (21G320)

@droidmonkey
Copy link
Member

OK I see what is happening, simple logic error. If quick unlock becomes unavailable then the function that resets the view bails out too fast before actually resetting the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants