Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: bundle java inside appimage ( or maybe provide a script to include it / repack appimage with it ) #153

Open
cg-cri-gl opened this issue Jun 29, 2024 · 1 comment
Labels
Feature New feature or request Java Related to Java (JRE, JDK)
Milestone

Comments

@cg-cri-gl
Copy link

cg-cri-gl commented Jun 29, 2024

Thanks for working on this project - and specifically from my p.o.v. - on building an appimage distributable.

The issue i am facing is that java isn't installed on my machine and also ( since i don't need java ever ) i wouldn't want to install it just for this one app (apk-editor-studio ) and let it sit around ....

Thus , could you please take into consideration including java with the appimage - probably this would be of help.

The other alternative / idea of " a script to include it / repack appimage with it" revolves around possible java copyright issue - although since the link i provided is from official appimage gh repo , and it doesn't mention anything about such issue , it probably isn't any issue at all...

Thanks !

@kefir500
Copy link
Owner

kefir500 commented Aug 8, 2024

Hi @cg-cri-gl,

Thanks for your feedback!

I have just answered the related question here, so let me quote myself:

No doubt, bundling Java with APK Editor Studio would be handy.
However, this would also bloat the size of the APK Editor Studio packages.
For example, some features require JDK (not just JRE) which can be around 200 MB.
So the APK Editor Studio would become ×5 larger in size, which is not the greatest result in my opinion.

Moreover, since APK Editor Studio is supported across 3 different platforms and is distributed via CI/CD, this would be a pain for me (as a single developer of this project) to support this kind of deployment.

However, I have plans on adding the automatic Java downloader which would download OpenJDK if it is not present on the target system. This feature is already partially implemented on my local machine, so I hope it will see the light of the day in the future releases.

Regarding the OpenJDK implementation, I'm planning to use Adoptium (which I believe is a modern version of the AdoptOpenJDK mentioned in your link).

@kefir500 kefir500 added Feature New feature or request Java Related to Java (JRE, JDK) labels Aug 8, 2024
@kefir500 kefir500 added this to the v1.8.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Java Related to Java (JRE, JDK)
Projects
None yet
Development

No branches or pull requests

2 participants