Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DailySummariesConfigのJsonキーが適切でない。 #37

Closed
3 tasks done
keiji opened this issue Jun 8, 2021 · 0 comments
Closed
3 tasks done

DailySummariesConfigのJsonキーが適切でない。 #37

keiji opened this issue Jun 8, 2021 · 0 comments
Labels
bug Something isn't working exposurewindow mode

Comments

@keiji
Copy link
Owner

keiji commented Jun 8, 2021 •
edited
Loading

minimum_risk_scoreではなくminimum_window_scoreの方が良い。

chino/Chino.Common/DailySummariesConfig.cs

Lines 51 to 52 in 698eb4f

[JsonProperty("minimum_risk_score")]
public double MinimumWindowScore { get; set; } = 0.0;

Close条件

  • コードを修正する
  • テストを修正する
  • 修正版をリリースする
@keiji keiji added bug Something isn't working exposurewindow mode labels Jun 9, 2021
@keiji keiji mentioned this issue Jun 9, 2021
Merged
@keiji keiji closed this as completed Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working exposurewindow mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keiji