Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LaunchTemplateVersion is not set after updating the scaling group #239

Closed
eytan-avisror opened this issue Feb 9, 2021 · 0 comments · Fixed by #237
Closed

LaunchTemplateVersion is not set after updating the scaling group #239

eytan-avisror opened this issue Feb 9, 2021 · 0 comments · Fixed by #237
Assignees
@backjo
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@eytan-avisror
Copy link
Collaborator

Seems we only set LaunchTemplateVersion status field during Discover, and not directly after we update the scaling group.
This causes the upgrade CR to also have the old version as unique identifier instead of the newer one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@backjo backjo

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

fix: set latest launch template version when creating a new version backjo/instance-manager
2 participants
@backjo @eytan-avisror