Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnets field should deduplicate if duplicate values are provided #339

Closed
eytan-avisror opened this issue Jan 26, 2022 · 0 comments · Fixed by #344
Closed

Subnets field should deduplicate if duplicate values are provided #339

eytan-avisror opened this issue Jan 26, 2022 · 0 comments · Fixed by #344
Labels
bug Something isn't working

Comments

@eytan-avisror
Copy link
Collaborator

If someone mistakenly provides dupe values, e.g.:

  subnets:
  - subnet-0310e3af3100225b9
  - subnet-0310e3af3100225b9
  - subnet-05c09777fce590171

The call will fail with:

"error": "provisioner eks reconcile failed: failed to update scaling group: ValidationError: Duplicate subnets specified: [subnet-0310e3af3100225b9]

We should consider having the controller dedupe values to avoid the error in this case and only use the two subnets.

Downside is that maybe we would like to explicitly provide this error if the user made a mistake and provided wrong subnets.

@eytan-avisror eytan-avisror added the bug Something isn't working label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant