Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Assertions not in the request #48

Closed
turbatuandrei opened this issue Mar 4, 2021 · 3 comments
Closed

[BUG] Assertions not in the request #48

turbatuandrei opened this issue Mar 4, 2021 · 3 comments

Comments

@turbatuandrei
Copy link

Describe the bug
When activating either of:

ckanext.saml2auth.want_assertions_signed
ckanext.saml2auth.want_assertions_or_response_signed

The signature is not included in the request.

image

ckanext-saml2auth version affected
v1.1.1

Expected behaviour
Signature is expected to be applied to the request.

@mbocevski mbocevski changed the title [BUG] [BUG] Assertions not in the request Mar 4, 2021
@mbocevski
Copy link
Member

The want_assertions_signed, want_response_signed and want_assertions_or_response_signed are parameters that are valid for the responses from the IDp: https://pysaml2.readthedocs.io/en/latest/howto/config.html#want-assertions-signed. What those configuration options mean is that the SP (in this case the CKAN acs) wants assertions or responses to be signed by the IDp in the SAML2 response.

If you want requests to be signed, then this parameter is what you need to set: https://pysaml2.readthedocs.io/en/latest/howto/config.html#authn-requests-signed. Note that this is true by default. So you need to have the key and cert configured through these options:

  • ckanext.saml2auth.key_file_path
  • ckanext.saml2auth.cert_file_path

@turbatuandrei
Copy link
Author

Thanks for the info, added authn_requests_signed: True to the config dict and all seems to work fine.

@FuhuXia
Copy link

FuhuXia commented Mar 8, 2023

@mbocevski Does this means that the requests are not signed by default?
@turbatuandrei Where do you add the authn_requests_signed: True?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants