Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dst starts, it's not fired. And when dst ends, it's fired twice. #563

Closed
tjpgt opened this issue Apr 1, 2021 · 3 comments
Closed

Comments

@tjpgt
Copy link

tjpgt commented Apr 1, 2021

Hello, thanks for the project, I have used it for a while and it help me a lot.

I didn't think much about day light saving before because I live in a country without it.

But now, I'm working on a project used in America and Europe, so I have to deal with it.

I find that when dst starts, the cron may not fire the job and fire the next day.

For example, if I have a job at 2:30, and the dst starts with 01:59:00->03:00:00, then it will skip the day. And if I have a job at 1:30, and the dst ends with 01:59:59->01:00:00, then it will fire twice.

Actually, I don't know what the proper behavior is. What about your alarm clock's behavior on your phone?

Can we have some config to change the behavior ?

@tjpgt
Copy link
Author

tjpgt commented Apr 1, 2021

And I've found some linux cron's behavior. If I have a job at 2:30, and dst starts with 01:59:00->03:00:00,it will fire at 03:00:00.(I think it's still a little surprising) And it won't fire twice when dst ends.

@intcreator
Copy link
Collaborator

with #639 we had some refactoring done with daylight savings jobs. could you see if that resolved your issue? if not, could you make a test case demonstrating the error? we have several tests for daylight savings already that should be similar to your use case

@tjpgt
Copy link
Author

tjpgt commented Apr 3, 2023

Yeah, I tried the latest version and I think the issue has been resolved. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants