fix: prevent jobs from stopping unexpectedly #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/threshold.test.ts:49
- Consider restoring the fake timers using clock.restore() in an afterEach block to ensure that timer state does not leak between tests.
const clock = sinon.useFakeTimers();
tests/cron.test.ts:40
- Ensure that fake timers are restored (using clock.restore()) after the test completes to avoid side effects in subsequent tests.
const clock = sinon.useFakeTimers();
intcreator
approved these changes
Apr 6, 2025
There was a problem hiding this comment.
just a couple of small notes that aren't a huge deal. I would say maybe we want wording that calls out the options to change the threshold more directly but I think most people just will be happy that the jobs don't stop executing because of this bug so it's fine
|
🎉 This PR is included in version 4.1.5-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
9 tasks
|
🎉 This PR is included in version 4.2.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
intcreator
added a commit
that referenced
this pull request
Apr 15, 2025
…980) <!--- Provide a general summary of your changes in the Title above (following the Conventional Commits standard) --> <!-- More infos: https://www.conventionalcommits.org --> <!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types--> ## Description <!--- Describe your changes in detail --> see #963 ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> fixes #962 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> see #962 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> see #963 ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard). --------- Co-authored-by: Pierre Cavin <me@sherlox.io> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
intcreator
pushed a commit
to WillianAgostini/node-cron
that referenced
this pull request
Apr 18, 2025
## [4.3.0](kelektiv/node-cron@v4.2.0...v4.3.0) (2025-04-15) ### ✨ Features * add options to handle cases where jobs could stop unexpectedly ([kelektiv#980](kelektiv#980)) ([994b93a](kelektiv@994b93a)), closes [kelektiv#963](kelektiv#963) [kelektiv#962](kelektiv#962) [kelektiv#962](kelektiv#962) [kelektiv#963](kelektiv#963)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #962.
Related Issue
Closes #962.
Motivation and Context
See #962.
How Has This Been Tested?
New test case added.
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).