-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release? #59
Comments
Same here. Just wrote code based off of the master branch. Was wondering why I was getting:
Thanks @marc2982 , I am finding schema to be very expressive for what I need to do. |
Same here 😭 >>> from schema import Schema, Optional
>>> s = Schema({Optional('foo', default=1)})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: __init__() got an unexpected keyword argument 'default'
__init__() got an unexpected keyword argument 'default' |
@skorokithakis: How's it looking? I'd propose that you delay any API decisions and merge #84 and #85. Then adjust the install instructions in the README for the new version number and get it out of the door! 😀 Issues like #80 or #83 don't seem to be problematic in the wild, so I'd argue that they might just as well be delayed for the next release. |
Or are there other things that absolutely need to get into the next release? |
I'm kinda having trouble replying to all your improvements :P I don't think there are any API decisions to be made, I'm sure a 0.3.2 release could easily be made from the current fixes. I'm just waiting for a fix in #85 to merge that, and then we can release. In my projects, I release minor revisions even for a single bugfix, since they're pretty cheap (although it depends on how active the project is, too). |
#85 is ready BTW. |
Merged, thank you! |
@keleshev, ready for a new release when you are. |
Hi maintainers, if something is holding up a new stable release, can you release master to PyPI as a beta release in the meantime, as it has some nice fixes? Let us know if there's anything community can do to help. |
@skorokithakis what's you PyPI username? |
It's "stochastic". |
@skorokithakis added you as maintainer. My feedback on the current release: Since last release several top-level names were introduced (like After that you can release the new version. Please ping me next time you release so I can review the changes. Keep it backwards-compatible. And thanks for helping out with the project. |
Before releasing I suggest to review and merge also pull request #65 |
Now that #65 is closed, is this a good time to release 0.3.2? |
Hey @skorokithakis and @keleshev, anything else holding up the next release, possibly that anyone else can help with? |
We need #97 or something like it before releasing. |
@keleshev, do you want to do the honours for this one? I'm not sure how the release process goes, do you just change the version to remove dev0, upload and commit, or do you bump the version to the next minor dev0 and release without committing 0.3.2? |
This release adds features that's why the version bump to |
@keleshev wrote:
Please review #90 (comment) |
By the way, shouldn't the next version in master be |
@skorokithakis ah, yeah, good catch. |
There hasn't been a release since last April and I would like to use the new defaulting functionality. Would you mind cutting a new release?
Thanks!
The text was updated successfully, but these errors were encountered: