Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #59

Closed
marc2982 opened this issue May 12, 2015 · 22 comments
Closed

New release? #59

marc2982 opened this issue May 12, 2015 · 22 comments

Comments

@marc2982
Copy link

There hasn't been a release since last April and I would like to use the new defaulting functionality. Would you mind cutting a new release?

Thanks!

@vinceaperri
Copy link

Same here. Just wrote code based off of the master branch. Was wondering why I was getting:

TypeError: __init__() got an unexpected keyword argument 'default'.

Thanks @marc2982 , I am finding schema to be very expressive for what I need to do.

@drgarcia1986
Copy link
Contributor

Same here 😭

>>> from schema import Schema, Optional
>>> s = Schema({Optional('foo', default=1)})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __init__() got an unexpected keyword argument 'default'
__init__() got an unexpected keyword argument 'default'

@sjakobi
Copy link
Contributor

sjakobi commented Sep 26, 2015

@skorokithakis: How's it looking?

I'd propose that you delay any API decisions and merge #84 and #85.

Then adjust the install instructions in the README for the new version number and get it out of the door! 😀

Issues like #80 or #83 don't seem to be problematic in the wild, so I'd argue that they might just as well be delayed for the next release.

@sjakobi
Copy link
Contributor

sjakobi commented Sep 26, 2015

Or are there other things that absolutely need to get into the next release?
Anything I can assist with?

@skorokithakis
Copy link
Collaborator

I'm kinda having trouble replying to all your improvements :P I don't think there are any API decisions to be made, I'm sure a 0.3.2 release could easily be made from the current fixes. I'm just waiting for a fix in #85 to merge that, and then we can release. In my projects, I release minor revisions even for a single bugfix, since they're pretty cheap (although it depends on how active the project is, too).

@sjakobi
Copy link
Contributor

sjakobi commented Sep 27, 2015

#85 is ready BTW.

@skorokithakis
Copy link
Collaborator

Merged, thank you!

@skorokithakis
Copy link
Collaborator

@keleshev, ready for a new release when you are.

@jab
Copy link
Contributor

jab commented Oct 14, 2015

Hi maintainers, if something is holding up a new stable release, can you release master to PyPI as a beta release in the meantime, as it has some nice fixes? Let us know if there's anything community can do to help.

@skorokithakis
Copy link
Collaborator

Only @keleshev can do that, unfortunately, or I would have. Paging @keleshev.

@keleshev
Copy link
Owner

@skorokithakis what's you PyPI username?

@skorokithakis
Copy link
Collaborator

It's "stochastic".

@keleshev
Copy link
Owner

@skorokithakis added you as maintainer.

My feedback on the current release: Since last release several top-level names were introduced (like MARKER and priorities), I think they are not part of public API, thus we need to either prefix them with underscore, or create an __all__ variable that excludes them.

After that you can release the new version.

Please ping me next time you release so I can review the changes. Keep it backwards-compatible. And thanks for helping out with the project.

@kosz85
Copy link

kosz85 commented Oct 15, 2015

Before releasing I suggest to review and merge also pull request #65

@jab
Copy link
Contributor

jab commented Oct 19, 2015

Now that #65 is closed, is this a good time to release 0.3.2?

@jab
Copy link
Contributor

jab commented Oct 26, 2015

Hey @skorokithakis and @keleshev, anything else holding up the next release, possibly that anyone else can help with?

@keleshev
Copy link
Owner

We need #97 or something like it before releasing.

@skorokithakis
Copy link
Collaborator

@keleshev, do you want to do the honours for this one? I'm not sure how the release process goes, do you just change the version to remove dev0, upload and commit, or do you bump the version to the next minor dev0 and release without committing 0.3.2?

@keleshev
Copy link
Owner

  • Change version to 0.4.0; commit.
  • python setup.py sdist upload.
  • Test pip install in a virtualenv; if all works:
    • Change version to 0.4.0-alpha (semver); commit.
    • Push to GitHub.

This release adds features that's why the version bump to 0.4.0. Somehow non-semver version 0.3.2.dev0 slipped into source, supposed to be 0.3.2-dev0 or 0.3.2-dev or, I prefer 0.3.2-alpha.

@jab
Copy link
Contributor

jab commented Oct 26, 2015

@keleshev wrote:

Somehow non-semver version 0.3.2.dev0 slipped into source

Please review #90 (comment)

@skorokithakis
Copy link
Collaborator

By the way, shouldn't the next version in master be 0.4.1-alpha, since 0.4.0 was just released?

@keleshev
Copy link
Owner

@skorokithakis ah, yeah, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants