Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForKind should return an error instead of panicing #38

Closed
lukasmalkmus opened this issue Dec 21, 2021 · 1 comment
Closed

ForKind should return an error instead of panicing #38

lukasmalkmus opened this issue Dec 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@lukasmalkmus
Copy link

The ForKind function panics for an unknown column type:

column/column.go

Line 115 in 1f327b4

panic(fmt.Errorf("column: unsupported column kind (%v)", kind))

But it would be nicer if it would error and be picked up by:

column/collection.go

Line 230 in 1f327b4

c.CreateColumn(k, ForKind(reflect.TypeOf(v).Kind()))

@kelindar kelindar added the enhancement New feature or request label Dec 21, 2021
@kelindar kelindar mentioned this issue Dec 22, 2021
Merged
@kelindar
Copy link
Owner

Added in the last PR #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelindar @lukasmalkmus