Defmt #39
Merged
Defmt #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
ryan-summers
requested changes
Mar 6, 2023
|
Sure thing! I'm also adding defmt::Format to other structs. |
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
ryan-summers
requested changes
Mar 6, 2023
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
|
CI is updated and it would be nice to change actions-rs with https://github.com/dtolnay/rust-toolchain as actions-rs has been unmaintained for quite some time now (2 years I think) |
ryan-summers
approved these changes
Mar 6, 2023
|
@elpiel Mind rounding things out with a |
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
|
Ahh my bad, it's fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the Host since docs are missing for it.
I also have an idea on using
AtomicUsize(atomic_polyfill) for the sockets (this will remove the requirement of&mutfor some methods) and implementing embedded_hal_async / embedded_hal: 0.2.0 traits in separate features.