Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ENV:EDITOR only works for nvim #249

Closed
hrai opened this issue Feb 7, 2024 · 2 comments
Closed

$ENV:EDITOR only works for nvim #249

hrai opened this issue Feb 7, 2024 · 2 comments

Comments

@hrai
Copy link

hrai commented Feb 7, 2024

When I set vim as $ENV:EDITOR no editor is opened.

I only get the output below:
image

#158

But when I set it to nvim are per this #157, I have similar issue as described here #242:
image

The editor is open but I can't trace what's going on in the editor.

@hrai
Copy link
Author

hrai commented Feb 7, 2024

Actually I identified the culprit to be -NoNewWindow flag that is a Windows bug.

Start-Process $Editor -ArgumentList $Arguments -Wait:$Wait -NoNewWindow

Here's the command I ran that would give this error behaviour on Windows Terminal.
Start-Process nvim -ArgumentList '"C:\_dev\yarn.lock" +0' -NoNewWindow

@kelleyma49 is it possible to add a flag to the FuzzyEdit command to have this -NoNewWindow as optional?

@hrai
Copy link
Author

hrai commented Feb 15, 2024

I disabled the keymap and added a workaround instead.

function FindFile
{
  Get-ChildItem . -Recurse -Attributes !Directory | Invoke-Fzf | % { vim $_ }
}
Set-Alias fe FindFile

@hrai hrai closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant