Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Completion causes permanent text misalignment #274

Open
Alfamari opened this issue Jun 16, 2024 · 6 comments
Open

Tab Completion causes permanent text misalignment #274

Alfamari opened this issue Jun 16, 2024 · 6 comments

Comments

@Alfamari
Copy link

After repeated use of tab completion the text will be permanently misaligned for the lifespan of the shell. It doesn't trigger on every one, but after enough tab completions it will inevitably trigger and persist for the duration of the shell. I initially thought it was an issue with windows terminal, but I've since switched to wezterm and am experiencing it there too.

Correct:

wezterm-gui_6LopWVSvSG

No extra newline:

wezterm-gui_W6Z27pcN4a

Incorrect:

wezterm-psfzf-text-misalignment-with-arrows

Extra newline:

wezterm-gui_cA2hRWNy35

@brian6932
Copy link

duplicate of #189

@kelleyma49
Copy link
Owner

I can recreate this. I believe it is related to this issue: gdamore/tcell@d1364d5. Please update your fzf and see if the issue is resolved.

@kelleyma49
Copy link
Owner

After further testing it doesn't look like that change fixed it and this is still an issue with fzf.

@Alfamari
Copy link
Author

Alfamari commented Oct 7, 2024

I can't say definitively that it is an issue with psfzf and not fzf, but I can say that after hacking together an inferior replacement for fzf tab completion with the help of AI, it isn't present. It also isn't present in any other project I've ever used that leverages fzf or any other use I've had with fzf. Heck, even within psfzf the issue isn't present in any of the other tools. I have only experienced this issue specifically and uniquely with the tab-completion part of psfzf and nowhere else. Unfortunate too because the tab-completion is arguably the most used and most useful feature.

But I also understand how complicated programming and project/dependency interactions can become so I don't mean to cast blame either and the truth is I don't know. I just want to give my observations in the hope that it can help narrow things down. And after trying my hand at a disappointing replacement I have an even greater respect for all of the issues this project has had to work around and find solutions for in addition to all of its cool little additions it adds to make things even nicer.

@kelleyma49
Copy link
Owner

kelleyma49 commented Oct 19, 2024

I have tried to debug but unfortunately I have made no progress. I am seeking help from the Windows Terminal community: microsoft/terminal#18085

@jvolden
Copy link

jvolden commented Nov 21, 2024

I tried looking into this but after reinstalling bat through cargo, I can no longer duplicate it. I can update if it comes back.

This is my cargo install --list if it helps. I'm on Windows 11.
bat v0.24.0:
bat.exe
cargo-update v16.0.0:
cargo-install-update-config.exe
cargo-install-update.exe
fd-find v10.2.0:
fd.exe
lsd v1.1.5:
lsd.exe
ripgrep v14.1.1:
rg.exe
zoxide v0.9.6:
zoxide.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants