-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it compatible with ruby 2.2 #91
Conversation
@@ -334,7 +334,7 @@ def at_shutdown( proc = nil, &block ) | |||
@shutdown_hooks << ( proc || block ) | |||
end | |||
|
|||
def pid_file( instance = instance ) | |||
def pid_file( instance = instance() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate it if you completely removed the ambiguity.
For example:
def pid_file an_instance = instance()
"... #{an_instance}.pid"
The nuclear option is to copy #pid_file
to a class method with an arity of 1 and then have the instance version have an arity of 0. This is a breaking change though.
Thanks! I have a small line comment, if you don't mind addressing :-). |
@marcbowes: fixed 😄 |
Make it compatible with ruby 2.2
Thanks. Do you need this released (to Rubygems) or are you happy to pull from GitHub? |
Rubygems release would be great! Thanks! |
Such speed, thanks @marcbowes for getting this through and @deees for the fix! |
Thanks! 👍 |
👍 |
Fixes:
@kennethkalmer @marcbowes