Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite to use inline snapshots #116

Open
billyjanitsch opened this issue Jun 6, 2021 · 0 comments · May be fixed by #117
Open

Refactor test suite to use inline snapshots #116

billyjanitsch opened this issue Jun 6, 2021 · 0 comments · May be fixed by #117

Comments

@billyjanitsch
Copy link
Collaborator

The current snapshot-based is getting unwieldy:

  • Some of the fixtures are quite large and it's increasingly hard to understand what each test is verifying and what to expect from the output.
  • It runs every test through every env, even though some of the tests' output is only useful to compare across a subset of the envs.
  • Including the input code as one of the snapshots was well-intentioned, but, in practice, it's hard to parse the snapshot file well enough to directly compare input/output.
  • GitHub's diff rendering of the snapshot file often fails to correspond snapshots based on their title, so the output is a mess.

I think we should try out inline snapshots with a new test suite that is more locally-scoped. We can include a few kitchen sink tests to get the high-level integration coverage that our current suite covers as well.

@billyjanitsch billyjanitsch linked a pull request Jun 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant