Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt "new-style" schema definition language syntax #450

Open
obi1kenobi opened this issue Aug 6, 2019 · 3 comments
Open

Adopt "new-style" schema definition language syntax #450

obi1kenobi opened this issue Aug 6, 2019 · 3 comments
Assignees
Labels
enhancement GraphQL compatibility Compatibility concerns relative to the GraphQL specification and standard

Comments

@obi1kenobi
Copy link
Contributor

Per graphql/graphql-js#1169

This replaces:

type Foo implements Bar, Baz { field: Type }

With:

type Foo implements Bar & Baz { field: Type }

With no changes to the common case of implementing a single interface.

We may need to update to a more up-to-date GraphQL core library if one exists.

@obi1kenobi
Copy link
Contributor Author

GraphQL core appears to have a newer version out than we are currently using. Assigning to @pmantica1 to take a look if that will resolve this issue.

@obi1kenobi obi1kenobi added enhancement GraphQL compatibility Compatibility concerns relative to the GraphQL specification and standard labels Aug 26, 2019
@pmantica1
Copy link
Contributor

Updating the GraphQL core version will not fix this issue. The interfaces implemented by an object are still delimited by "," and not "&" as shown in the link below.
https://github.com/graphql-python/graphql-core/blob/master/graphql/utils/schema_printer.py#L131

The interfaces are delimited by "&" though in the GraphQL core-next library as shown below.
https://github.com/graphql-python/graphql-core-next/blob/master/src/graphql/utilities/schema_printer.py#L154

@obi1kenobi
Copy link
Contributor Author

Ok so this would require dropping Python 2 support, which might be worth it for this. @pmantica1, could you check what it would take to do the migration? I believe there may be some breaking changes between graphql-core and graphql-core-next, so we should put together a migration plan if it's not as simple as changing dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GraphQL compatibility Compatibility concerns relative to the GraphQL specification and standard
Projects
None yet
Development

No branches or pull requests

2 participants