Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Review can not be requested from author" #11

Open
Warchant opened this issue Nov 18, 2019 · 2 comments
Open

"Review can not be requested from author" #11

Warchant opened this issue Nov 18, 2019 · 2 comments

Comments

@Warchant
Copy link

Warchant commented Nov 18, 2019

4 developers work on a single repo. If one developer creates a PR, and he is in the "reviewers" list, action fails with "Review can not be requested from author".

Expected behavior:
Author is skipped, all other users added as reviewers.

Actual behavior:
0 reviewers added.

Config:

# Set to true to add reviewers to pull requests
addReviewers: true

# Set to author to set pr creater as assignee
addAssignees: author

# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
  - deva
  - devb
  - devc
  - devd

# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0

# A list of keywords to be skipped the process that add reviewers if pull requests include it
skipKeywords:
  - wip 
@kentaro-m
Copy link
Owner

kentaro-m commented Nov 20, 2019

Hi @Warchant ! Thanks for reporting the problem.

The message Review can not be requested from author is shown, when the PR author is added as a reviewer to the pull request. This behavior is specification on GitHub.

Auto Assign Action excludes the PR author from reviewers. I checked your repository. I have a concern that a format of reviewer list may have caused the exclusion process to fail.

VeriBlock/alt-integration#39

I want you to try modifying to Warchant from warchant in the reviewers' list.

Usernames must be handled in lowercase on the application. I think to need to fix it.

@PrinsFrank
Copy link

Had the same issue in a private repo run, different casing was indeed the problem in my case;

# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
  - deva
  - devb
  - devc
  - devd

# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0

where the user that commits has a username "Deva" results in this behaviour. Changing it to:

# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
  - Deva
  - devb
  - devc
  - devd

# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0

Fixes the issue.

As all other username functionality on github is case insensitive this is counter-intuitive and I had to come here to see this as well, maybe this can be changed to accept any case variant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants