This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 247
Handle escaping and single quotes #158
Merged
kentcdodds
merged 1 commit into
kentcdodds:master
from
brucejo75:Escaping_and_single_quotes
Dec 21, 2017
Merged
Handle escaping and single quotes #158
kentcdodds
merged 1 commit into
kentcdodds:master
from
brucejo75:Escaping_and_single_quotes
Dec 21, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 57 63 +6
Branches 13 14 +1
=====================================
+ Hits 57 63 +6
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Dec 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks both of you!
This was referenced Dec 22, 2017
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: fix #148
Why: cross-env-shell does not work for macOS
How: The best possible way by @brucejo75
ALL credit goes to @brucejo75 i just making the PR because cross-env-shell does not work cross platform :)